chore: Don't log errors for accepting the EULA via the system property#13681
Open
kezz wants to merge 2 commits intoPaperMC:mainfrom
Open
chore: Don't log errors for accepting the EULA via the system property#13681kezz wants to merge 2 commits intoPaperMC:mainfrom
kezz wants to merge 2 commits intoPaperMC:mainfrom
Conversation
Strokkur424
approved these changes
Mar 5, 2026
paper-server/patches/sources/net/minecraft/server/Main.java.patch
Outdated
Show resolved
Hide resolved
kennytv
approved these changes
Mar 5, 2026
Contributor
|
why should this even be a warning? i feel like |
Strokkur424
reviewed
Mar 5, 2026
Comment on lines
75
to
76
| + } | ||
| + if (!eula.hasAgreedToEULA() && !eulaAgreed) { |
Member
There was a problem hiding this comment.
You could maybe even put this into an else-if statement instead, might be cleaner.
Suggested change
| + } | |
| + if (!eula.hasAgreedToEULA() && !eulaAgreed) { | |
| + } else if (!eula.hasAgreedToEULA()) { |
NoahvdAa
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not really necessary to log this as an error, plus we can rename it now.