Skip to content

[ci skip] chore(jd): ChunkGenerator improvements #13655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Warriorrrr merged 2 commits into from
Apr 11, 2026
+11 −11
Merged

[ci skip] chore(jd): ChunkGenerator improvements #13655

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50dc68a
jd: grammar error in shouldGenerateDecorations
Uhuli Feb 25, 2026
379c249
chore(jd): ChunkGenerator improvements
Uhuli Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions paper-api/src/main/java/org/bukkit/generator/ChunkGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@
* A chunk generator is responsible for the initial shaping of an entire
* chunk. For example, the nether chunk generator should shape netherrack and
* soulsand.
*
* <p>
* A chunk is generated in multiple steps, those steps are always in the same
* order. Between those steps however an unlimited time may pass. This means, a
* chunk may generate until the surface step and continue with the bedrock step
* after one or multiple server restarts or even after multiple Minecraft
* versions.
*
* The order of generation is as follows
* <p>
* The order of generation is as follows:
* <ol>
* <li>{@link #generateNoise(WorldInfo, Random, int, int, ChunkData)}</li>
* <li>{@link #generateSurface(WorldInfo, Random, int, int, ChunkData)}</li>
Expand All @@ -39,7 +39,7 @@
* {@link #getBaseHeight(WorldInfo, Random, int, int, HeightMap)}
* <b>must</b> be completely thread safe and able to handle multiple concurrent
* callers.
*
* <p>
* Some aspects of world generation can be delegated to the Vanilla generator.
* The following methods can be overridden to enable this:
* <ul>
Expand Down Expand Up @@ -167,7 +167,7 @@ public void generateCaves(@NotNull WorldInfo worldInfo, @NotNull Random random,
* <p>
* Notes:
* <p>
* If <code>null</code> is returned, than Vanilla biomes are used.
* If <code>null</code> is returned, then Vanilla biomes are used.
* <p>
* This method only gets called once when the world is loaded. Returning
* another {@link BiomeProvider} later one is not respected.
Expand Down Expand Up @@ -375,7 +375,7 @@ public boolean isParallelCapable() {
* The Vanilla noise is generated <b>before</b>
* {@link #generateNoise(WorldInfo, Random, int, int, ChunkData)} is called.
* <p>
* This is method is not called (and has therefore no effect), if
* This method is not called (and has therefore no effect), if
* {@link #shouldGenerateNoise(WorldInfo, Random, int, int)} is overridden.
*
* @return true if the server should generate Vanilla noise
Expand Down Expand Up @@ -412,7 +412,7 @@ public boolean shouldGenerateNoise(@NotNull WorldInfo worldInfo, @NotNull Random
* {@link #generateSurface(WorldInfo, Random, int, int, ChunkData)} is
* called.
* <p>
* This is method is not called (and has therefore no effect), if
* This method is not called (and has therefore no effect), if
* {@link #shouldGenerateSurface(WorldInfo, Random, int, int)} is overridden.
*
* @return true if the server should generate Vanilla surface
Expand Down Expand Up @@ -464,7 +464,7 @@ public boolean shouldGenerateBedrock() {
* The Vanilla caves are generated <b>before</b>
* {@link #generateCaves(WorldInfo, Random, int, int, ChunkData)} is called.
* <p>
* This is method is not called (and has therefore no effect), if
* This method is not called (and has therefore no effect), if
* {@link #shouldGenerateCaves(WorldInfo, Random, int, int)} is overridden.
*
* @return true if the server should generate Vanilla caves
Expand Down Expand Up @@ -501,7 +501,7 @@ public boolean shouldGenerateCaves(@NotNull WorldInfo worldInfo, @NotNull Random
* The Vanilla decoration are generated <b>before</b> any
* {@link BlockPopulator} are called.
* <p>
* This is method is not called (and has therefore no effect), if
* This method is not called (and has therefore no effect), if
* {@link #shouldGenerateDecorations(WorldInfo, Random, int, int)} is overridden.
*
* @return true if the server should generate Vanilla decorations
Expand Down Expand Up @@ -536,7 +536,7 @@ public boolean shouldGenerateDecorations(@NotNull WorldInfo worldInfo, @NotNull
* Gets if the server should generate Vanilla mobs after this
* ChunkGenerator.
* <p>
* This is method is not called (and has therefore no effect), if
* This method is not called (and has therefore no effect), if
* {@link #shouldGenerateMobs(WorldInfo, Random, int, int)} is overridden.
*
* @return true if the server should generate Vanilla mobs
Expand Down Expand Up @@ -568,7 +568,7 @@ public boolean shouldGenerateMobs(@NotNull WorldInfo worldInfo, @NotNull Random
* Gets if the server should generate Vanilla structures after this
* ChunkGenerator.
* <p>
* This is method is not called (and has therefore no effect), if
* This method is not called (and has therefore no effect), if
Comment thread
Uhuli marked this conversation as resolved.
* {@link #shouldGenerateStructures(WorldInfo, Random, int, int)} is overridden.
*
* @return true if the server should generate Vanilla structures
Expand Down
Loading