Add getLastPing to Player #13552
Open
Add getLastPing to Player #13552
+36
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Would it make sense to return |
Contributor
Author
|
It would seem weird for that to be a Duration while getPing() right next to it is in ms, plus ms seems to be the generally accepted resolution on "the internets." But it's easy enough to change if there's more demand for it I suppose. I just assume that even if it was a Duration, the absolute majority use-case would be people converting it to milliseconds. |
lynxplay
reviewed
Jan 15, 2026
Contributor
lynxplay
left a comment
lynxplay
left a comment
There was a problem hiding this comment.
We hardforked, no need for comments.
lynxplay
reviewed
Jan 15, 2026
lynxplay
reviewed
Jan 15, 2026
Owen1212055
requested changes
Jan 16, 2026
Member
Owen1212055
left a comment
Owen1212055
left a comment
There was a problem hiding this comment.
This should not be on Player, rather the PlayerCommonConnection.
Also include some of the other ping stuff.
github-project-automation
bot
moved this from Waiting For Author
to Changes required
in Paper PR Queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes most recent ping in milliseconds on a Player. The default
Player.getPing()represents an average over time, but it is very nice to be able to actually see their most recent ping.