Skip to content

Conversation

@Doc94
Copy link
Member

@Doc94 Doc94 commented Jan 11, 2026

Fixes #13542 by adding new methods for get the moon phase using the location for work with the Environment Attributes

@Doc94 Doc94 requested a review from a team as a code owner January 11, 2026 01:17
@github-project-automation github-project-automation bot moved this to Awaiting review in Paper PR Queue Jan 11, 2026
@Doc94 Doc94 force-pushed the feature/moon-phase-update branch from 53e286f to 7f72d1f Compare January 11, 2026 02:03
@Lulu13022002
Copy link
Contributor

It might be better to wait for the upcoming environmental attribute api and just fetch the dimensional value for now like the methods around CraftWorld#isNatural (which has a todo if you want to look at it).

@Doc94
Copy link
Member Author

Doc94 commented Jan 11, 2026

It might be better to wait for the upcoming environmental attribute api and just fetch the dimensional value for now like the methods around CraftWorld#isNatural (which has a todo if you want to look at it).

then can move this to just deprecate the method?

@lynxplay
Copy link
Contributor

Yes, just deprecate the method for now with no alternative + mention upcoming env attribute API.
net.minecraft.world.attribute.EnvironmentAttributeSystem#getDimensionValue should suffice for a "good enough" deprecation.

@Doc94 Doc94 force-pushed the feature/moon-phase-update branch from e06a68f to 388e13c Compare January 17, 2026 00:12
@Doc94 Doc94 changed the title Deprecate RegionAccessor#getMoonPhase in favor of support Environment Attributes Deprecate RegionAccessor#getMoonPhase Jan 17, 2026
@Lulu13022002 Lulu13022002 changed the title Deprecate RegionAccessor#getMoonPhase Update RegionAccessor#getMoonPhase to take in account environment attributes from dimension type Jan 17, 2026
@Lulu13022002 Lulu13022002 changed the title Update RegionAccessor#getMoonPhase to take in account environment attributes from dimension type Update RegionAccessor#getMoonPhase to take in account environment attributes from world Jan 17, 2026
@Lulu13022002 Lulu13022002 force-pushed the feature/moon-phase-update branch from 495f5f4 to edc03b1 Compare January 17, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Awaiting review

Development

Successfully merging this pull request may close these issues.

RegionAccessor#getMoonPhase is outdated

3 participants