Cache the climbing check in activation range#12764
Merged
Owen1212055 merged 11 commits intoPaperMC:dev/26.1from Apr 5, 2026
Merged
Cache the climbing check in activation range#12764Owen1212055 merged 11 commits intoPaperMC:dev/26.1from
Owen1212055 merged 11 commits intoPaperMC:dev/26.1from
Conversation
Toffikk
force-pushed
the
dev/cache-climbing
branch
from
9228d26 to
097b19f
Compare
Toffikk
changed the title
Toffikk
force-pushed
the
dev/cache-climbing
branch
from
097b19f to
be20af6
Compare
Owen1212055
reviewed
Jun 29, 2025
paper-server/patches/features/0003-Entity-Activation-Range-2.0.patch
Outdated
Show resolved
Hide resolved
Toffikk
force-pushed
the
dev/cache-climbing
branch
from
1c2bf20 to
cdb40e3
Compare
Owen1212055
approved these changes
Jun 30, 2025
github-project-automation
bot
moved this from Awaiting review
to Awaiting final testing
in Paper PR Queue
Contributor
Author
|
rebased to .7 |
Contributor
Author
|
rebased for 1.21.9)) |
Contributor
Author
|
rebased this for 1.21.11 |
Contributor
Author
|
rebased again^ |
Contributor
Author
|
hey, don’t mean to push or anything, but could this get looked at during the next pr party? all this does is a simple one-line change too so it shouldn’t be a hassle |
Contributor
Author
|
hey, this pr has been approved for 9 months now. is there a chance it'll get merged before the 1 year anniversary? xD |
Contributor
Author
|
@Owen1212055 I rebased this for 26.1.1 |
github-project-automation
bot
moved this from Awaiting final testing
to Merged
in Paper PR Queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr aims to reduce the overhead of checking multiple times per tick if an entity is climbing. It does it by caching the last climbing block pos and checking if its the same as the current pos and returning early.
In my testing it helps to reduce the tick time spent on entities and the climbing related logic such as
setClimbingnow taking 0.02% of the tick time instead of 0.06%Before:
https://spark.lucko.me/cV9CmdEmwJ
After:
https://spark.lucko.me/7PDoTbgYhA
Entities on which these sparks were conducted are spiders
note: a version of this patch was also used in forks such as Pufferfish and Airplane and provided great results when paired with huge entity numbers