Refactor/173 use proper retry#183
Merged
SimOnPanw merged 6 commits intoPaloAltoNetworks:mainfrom Mar 14, 2025
Merged
Conversation
* Fix unit test by using full function/method/object path * Rename unit to test_unit python file * Move data information into a specific python file
* Add some basic test by using responses library, that permit to simplify the request mock. We add test before the retry change to keep all basic fonctionnalities
* Retry class permit to retry requests and to use requests session * Add retry_number property on PrismaCloudAPI used by Retry class * Update test_execute_compute_retry_failed_for_credentials_list test to use retry_number instead of retry_wait
Collaborator
|
@mgappa Thank you very much for your work Marian ! 🥇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To use less memory consumption, we must, first of all, add some tests on the current code and, second of all, apply some refactoring on the retry part. On this PR, we add:
unit.pytest fileMotivation and Context
This PR is the first step for the issue #173
How Has This Been Tested?
To test the code, you must install the dependencies in the
requirements_test.txtfile, with thepip install -r requirements_test.txtcommand. Then, you can execute all tests with the following commandcoverage run -m unittest discover -v -s "./tests" -p "test*.py". Finally, you can look at the coverage result by taping the commandcoverage report -mor if you are looking for a nicer presentation, you can tape the commandcoverage htmlScreenshots (if appropriate)
Coverage on the
mainbranch:Coverage on the
mgappa:refactor/173_use_proper_retrybranch:Report:
Types of changes
Checklist