[BugFix] Compatibility fix for download feature links#6276
Open
TBD1 wants to merge 3 commits intoPaddlePaddle:developfrom
Open
[BugFix] Compatibility fix for download feature links#6276TBD1 wants to merge 3 commits intoPaddlePaddle:developfrom
TBD1 wants to merge 3 commits intoPaddlePaddle:developfrom
Conversation
|
Thanks for your contribution! |
xiaoxiaohehe001
previously approved these changes
Jan 29, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6276 +/- ##
==========================================
Coverage ? 68.13%
==========================================
Files ? 388
Lines ? 51770
Branches ? 8061
==========================================
Hits ? 35275
Misses ? 13931
Partials ? 2564
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kevincheng2
requested changes
Jan 30, 2026
| feature_info = f"type=paddle.Tensor, shape={feature.shape}, dtype={feature.dtype}" | ||
| elif isinstance(feature, np.ndarray): | ||
| feature_info = f"type=np.ndarray, shape={feature.shape}, dtype={feature.dtype}" | ||
| else: |
Collaborator
There was a problem hiding this comment.
音频场景这里拿到的 feature 是一个list，直接 feature.shape 会报错，可以再加一个list，打印一下长度
|
|
||
| try: | ||
| if isinstance(link, list) and len(link) > 0: | ||
| link = link[0] |
Collaborator
Author
There was a problem hiding this comment.
1131行会循环从bos_links取url下载，目前暂定匹配list[list[str], list[str], ...]这种形式
| else: | ||
| feature_info = f"type={type(feature).__name__}" | ||
|
|
||
| llm_logger.info(f"request {request.request_id} async download feature success: {feature_info}") |
Collaborator
There was a problem hiding this comment.
这里是不是可以再加一个计时，打印一下这条请求下载feature共耗时多少
kevincheng2
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
修复FD多模download feature不兼容链路二维list的问题
Modifications
1.utils.py增加二维List判断
2.增加bos download feature模块log信息
Usage or Command
Accuracy Tests
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.