Typehints for ALPHA7#83
Typehints for ALPHA7#83xXSirGamesXx wants to merge 5 commits intoPEMapModder:masterfrom xXSirGamesXx:master
Conversation
| * @return HereAuth | ||
| */ | ||
| public function getPlugin(){ | ||
| public function getPlugin() : \pocketmine\plugin\Plugin { |
SOF3
left a comment
There was a problem hiding this comment.
You didn't update the declared API version.
|
Done |
|
ALPHA8 is coming soon though. I'll wait for it before updating. |
|
What should i do whit this error in ALPHA7? 14.09 11:50:18 [Server] Server thread/CRITICAL Could not pass event 'pocketmine\event\server\DataPacketSendEvent' to 'LeoHarduA v4.0.0': Return value of pocketmine\entity\Entity::getId() must be of the type integer, null returned on HereAuth\EventRouter |
Introduction
Relevant issues
Fixes #80
Changes (ABC)
API changes
Allows for 3.0.0-ALPHA7
Behavioural changes
Configuration changes
Backwards compatibility
None
Follow-up
Sorry about the last pr, was really messy
Tests