Conversation
Member
|
The changes look straight forward. You might want to run |
There was a problem hiding this comment.
Pull request overview
This PR improves clarity of RNG-related error messages for PCG RNG platform functions across the Python CVM RNG model and the Rust QASM engine, addressing missed cases from PR #267.
Changes:
- Updates Python
RNGModelstringification and refines error handling/messages for invalid RNG index and unsupported RNG functions. - Improves Rust QASM
evaluate_rng_modelsparse error messages for RNG* platform function calls (argument count/type and unknown function name).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| python/quantum-pecos/src/pecos/engines/cvm/rng_model.py | Refines RNG model display string; changes exception/message for invalid RNGindex; updates unsupported RNG function error text. |
| crates/pecos-qasm/src/engine.rs | Replaces non-interpolated string literals with format! and makes RNG platform-function parse errors more specific/consistent. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
qartik
requested changes
Mar 19, 2026
Collaborator
qartik
left a comment
qartik
left a comment
There was a problem hiding this comment.
Also, see the unresolved comments from Copilot.
qartik
approved these changes
Mar 20, 2026
ciaranra
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better error messages for encountering errors using pcg rng that were missed in #267