Prevent crash when dragging a folder into its own child#701
Merged
adriengivry merged 3 commits intoOverload-Technologies:mainfrom Apr 14, 2026
Merged
Prevent crash when dragging a folder into its own child#701adriengivry merged 3 commits intoOverload-Technologies:mainfrom
adriengivry merged 3 commits intoOverload-Technologies:mainfrom
Conversation
adriengivry
requested changes
Apr 14, 2026
adriengivry
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a crash in the Asset Browser when a folder is dragged and dropped into one of its own descendants.
The fix adds a local guard in the folder drag-and-drop handler to detect invalid parent->child (or self) moves before filesystem rename/copy operations are executed.
When such a move is detected, the operation is safely ignored and a warning is logged.
Related Issue(s)
Fixes #699
Review Guidance
Please focus review on:
AssetBrowser.cppScreenshots/GIFs
N/A (behavioral crash fix; no UI change)
Checklist
I have updated the documentation accordingly