fix: dataSource of CachedVideoPlayerPlus.file is not a valid file path#103
Merged
OutdatedGuy merged 1 commit intoOutdatedGuy:mainfrom Jul 26, 2025
wlodzix:fix_local_file_path
Merged
fix: dataSource of CachedVideoPlayerPlus.file is not a valid file path#103OutdatedGuy merged 1 commit intoOutdatedGuy:mainfrom wlodzix:fix_local_file_path
OutdatedGuy merged 1 commit intoOutdatedGuy:mainfrom
wlodzix:fix_local_file_path
Conversation
… to just absoulte.path
2 tasks
2 tasks
Owner
|
@wlodzix thanks a bunch for the PR and the detailed bug description. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found out that issue with playing local files may be related to wrong path provided to
Value passed here was actually URI string, which includes the file:// scheme — so it ends up being:
/file:/data/user/0/...
But File constructor expects a file system path, like:
/data/user/0/your.app/cache/....mp4
So changing the way dataSource is created for CachedVideoPlayerPlus.file constructor seems to fix the issue.