fix: split publish/finality handling with phased flow and timeouts#19
Open
fix: split publish/finality handling with phased flow and timeouts#19
Conversation
lupuszr
commented
Dec 22, 2025
lupuszr
commented
- add phased DKG adapter and use publish+mint phases, enqueue finality jobs
- introduce job defaults for publish/finality timeouts (3m publish, 15m finality)
- add mint_submitted status migration and update setup to include it
- add phased DKG adapter and use publish+mint phases, enqueue finality jobs - introduce job defaults for publish/finality timeouts (3m publish, 15m finality) - add mint_submitted status migration and update setup to include it
lupuszr
force-pushed
the
feature-publisher-worker-split
branch
from
cd7dd99 to
dd0fcae
Compare
zsculac
reviewed
Dec 29, 2025
| // If dkg.js didn't set readyForMint, infer it from status/minAcks | ||
| const readyForMint = | ||
| publishResult?.readyForMint ?? | ||
| (publishStatus === "COMPLETED" || minAcksReached === true); |
Contributor
There was a problem hiding this comment.
Should this be && instead of ||?
zsculac
reviewed
Dec 29, 2025
| const readyForMint = | ||
| publishResult?.readyForMint ?? | ||
| (publishStatus === "COMPLETED" || minAcksReached === true); | ||
| publishResult.readyForMint = readyForMint; |
Contributor
There was a problem hiding this comment.
why do we set this if we don't use it again?
publishResult.readyForMint = readyForMint;
zsculac
approved these changes
Dec 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.