ci: drop hard-pinned pnpm version in docgen workflows#168
Merged
Conversation
Let pnpm/action-setup@v4 resolve the version from package.json#packageManager so workflows don't drift when the package manager pin is bumped. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for openzeppelin-docs-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
stevep0z
approved these changes
May 15, 2026
Collaborator
stevep0z
left a comment
stevep0z
left a comment
There was a problem hiding this comment.
LGTM. Thanks @ernestognw !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generate-api-docs-*.ymlworkflows hard-pinpnpm/action-setup@v4toversion: 10.17.1, but chore: pin pnpm to 11.1.0 + 7-day minimumReleaseAge #165 bumpedpackage.json#packageManagertopnpm@11.1.0. The setup action enforces consistency between the two and fails withERR_PNPM_BAD_PM_VERSION(see run 25941406850).version:input lets the action resolve the version frompackage.json#packageManager, matching whatlint.ymlalready does. Future pnpm bumps viapackage.jsonwon't require touching workflow files.Test plan
workflow_dispatchon this branch; confirm the Setup pnpm step succeeds.🤖 Generated with Claude Code