Skip to content

Conversation

@immrsd
Copy link
Contributor

@immrsd immrsd commented Dec 31, 2025

No description provided.

@immrsd immrsd self-assigned this Dec 31, 2025
@netlify
Copy link

netlify bot commented Dec 31, 2025

Deploy Preview for openzeppelin-docs-v2 ready!

Name Link
🔨 Latest commit 37455fd
🔍 Latest deploy log https://app.netlify.com/projects/openzeppelin-docs-v2/deploys/69551b7db4ed210008d91837
😎 Deploy Preview https://deploy-preview-111--openzeppelin-docs-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

sure you are using the same compiler version to build the UDC class (and the release profile).

The latest version of the UDC available in the `openzeppelin_presets` package was compiled with **Cairo v2.13.1** (release profile) and the resulting class hash is `0x01b2df6d8861670d4a8ca4670433b2418d78169c2947f46dc614e69f333745c8`.
The latest version of the UDC available in the `openzeppelin_presets` package was compiled with **Cairo v2.11.4** (release profile) and the resulting class hash is `0x01b2df6d8861670d4a8ca4670433b2418d78169c2947f46dc614e69f333745c8`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted the changes since the resulting class hash and contract address would be incorrect. We should decide if we want to:
A. re-deploy UDC instances (built with Cairo 2.13.1 and 3.0.0 of the library) to all networks and update the guide
B. keep the already deployed instances; in that case we should clearly state what commit/tag of our library should be used for compiling and deploying UDC instance to a custom network

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vote we go with B. New compiler versions doesn't bring any benefits to the UDC implementation and this way the addresses will stay consistent throughout and reliable regardless of the library and Cairo upgrades

Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants