-
Notifications
You must be signed in to change notification settings - Fork 8
Cairo: fix 3.x links #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Cairo: fix 3.x links #111
Conversation
✅ Deploy Preview for openzeppelin-docs-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| sure you are using the same compiler version to build the UDC class (and the release profile). | ||
|
|
||
| The latest version of the UDC available in the `openzeppelin_presets` package was compiled with **Cairo v2.13.1** (release profile) and the resulting class hash is `0x01b2df6d8861670d4a8ca4670433b2418d78169c2947f46dc614e69f333745c8`. | ||
| The latest version of the UDC available in the `openzeppelin_presets` package was compiled with **Cairo v2.11.4** (release profile) and the resulting class hash is `0x01b2df6d8861670d4a8ca4670433b2418d78169c2947f46dc614e69f333745c8`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted the changes since the resulting class hash and contract address would be incorrect. We should decide if we want to:
A. re-deploy UDC instances (built with Cairo 2.13.1 and 3.0.0 of the library) to all networks and update the guide
B. keep the already deployed instances; in that case we should clearly state what commit/tag of our library should be used for compiling and deploying UDC instance to a custom network
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I vote we go with B. New compiler versions doesn't bring any benefits to the UDC implementation and this way the addresses will stay consistent throughout and reliable regardless of the library and Cairo upgrades
ericnordelo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! LGTM!
No description provided.