Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughComprehensive upgrade and refactoring across the Compact smart contracts framework: bumps language version to 0.21.0, restructures simulator architecture using base factory pattern, renames token transfer parameters from Changes
Estimated code review effort🎯 5 (Critical) | ⏱️ ~120 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This reverts commit 3af8a05.
Co-authored-by: Andrew Fleming <fleming-andrew@protonmail.com> Signed-off-by: ⟣ €₥ℵ∪ℓ ⟢ <34749913+emnul@users.noreply.github.com>
Co-authored-by: Andrew Fleming <fleming-andrew@protonmail.com> Signed-off-by: ⟣ €₥ℵ∪ℓ ⟢ <34749913+emnul@users.noreply.github.com>
|
@andrew-fleming RE: Compact tools changes Really the only change that's 100% necessary is the archive directory filtering in Should those sync changes be reverted for now? |
@emnul aint no thing. To be fair, we haven't been able to publish 😢 now, I'm wondering if we should be running build for contracts from the tools package bc it's pretty specific for how we use it
I'd say yeah, if you don't mind. Let's revert those changes to keep this PR clean so we're not yoloing anything. Measure twice, cut once |
| type ZswapCoinPublicKey = { bytes: Uint8Array }; | ||
|
|
||
| type ContractAddress = { bytes: Uint8Array }; | ||
|
|
||
| type Either<A, B> = { is_left: boolean; left: A; right: B }; |
There was a problem hiding this comment.
I think that's a good idea. It's a small dx improvement but everyone benefits. Worst case, it's something we can offer
Co-authored-by: Andrew Fleming <fleming-andrew@protonmail.com> Signed-off-by: ⟣ €₥ℵ∪ℓ ⟢ <34749913+emnul@users.noreply.github.com>
Co-authored-by: Andrew Fleming <fleming-andrew@protonmail.com> Signed-off-by: ⟣ €₥ℵ∪ℓ ⟢ <34749913+emnul@users.noreply.github.com>
Co-authored-by: Andrew Fleming <fleming-andrew@protonmail.com> Signed-off-by: ⟣ €₥ℵ∪ℓ ⟢ <34749913+emnul@users.noreply.github.com>
Co-authored-by: Andrew Fleming <fleming-andrew@protonmail.com> Signed-off-by: ⟣ €₥ℵ∪ℓ ⟢ <34749913+emnul@users.noreply.github.com>
Co-authored-by: Andrew Fleming <fleming-andrew@protonmail.com> Signed-off-by: ⟣ €₥ℵ∪ℓ ⟢ <34749913+emnul@users.noreply.github.com>
Co-authored-by: Andrew Fleming <fleming-andrew@protonmail.com> Signed-off-by: ⟣ €₥ℵ∪ℓ ⟢ <34749913+emnul@users.noreply.github.com>
andrew-fleming
left a comment
There was a problem hiding this comment.
Left a tiny suggestion but LGTM! Nice work, sir 🚀
Co-authored-by: Andrew Fleming <fleming-andrew@protonmail.com> Signed-off-by: ⟣ €₥ℵ∪ℓ ⟢ <34749913+emnul@users.noreply.github.com>
This PR is part of #364 .
fromvariables tofromAddressto avoid new keyword collisions.compact fixup)archivecontracts. It should be removed in Add new compiler flag to skip directories #367createSimulatorfactory functionaddress.tsfiles.as(ROLE)syntaxencodeToAddressto catch changes toContractAddressrequirements and meet new type expectationsarchivecontracts from testsSummary by CodeRabbit
New Features
Bug Fixes
Chores