add kor translation#966
Conversation
添加了韩文翻译
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new Korean translation file (ko.ts). The review feedback highlights several issues resulting from copying the Chinese translation template, such as incorrect variable and export names (zhCn instead of ko), leftover Chinese comments and font names, and the use of full-width Chinese punctuation marks. Code suggestions have been provided to resolve these issues.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| @@ -0,0 +1,205 @@ | |||
| const zhCn = { | |||
There was a problem hiding this comment.
变量名被复制粘贴为 zhCn 而不是 ko。应该将其重命名为 ko，以匹配韩语本地化文件名并避免混淆。另外，请确保在 packages/webgal/src/config/language.ts 中注册并导入此韩语翻译文件。
| const zhCn = { | |
| const ko = { |
| @@ -0,0 +1,205 @@ | |||
| const zhCn = { | |||
| // 通用 | |||
There was a problem hiding this comment.
注释是中文的（// 通用）。应该将其翻译为韩语（// 공통）或英语（// Common）以匹配本地化文件。
| // 通用 | |
| // 공통 |
| }, | ||
| about: { | ||
| title: 'WebGAL에 관하여', | ||
| subTitle: 'WebGAL：오픈 소스 웹 기반 비주얼 노벨 엔진', |
There was a problem hiding this comment.
使用标准冒号 : 代替全角冒号 ： 以保持一致性。
| subTitle: 'WebGAL：오픈 소스 웹 기반 비주얼 노벨 엔진', | |
| subTitle: 'WebGAL: 오픈 소스 웹 기반 비주얼 노벨 엔진', |
| options: { | ||
| resourceHanRounded: '본고딕', | ||
| siYuanSimSun: '본명조', | ||
| SimHei: '黑体', |
There was a problem hiding this comment.
将 SimHei 的字体名称留在了中文（黑体）。应该将其翻译为韩语（例如 '고딕'）或英语（'Sans'），就像英文翻译中那样。
| SimHei: '黑体', | |
| SimHei: '고딕', |
| }, | ||
| saving: { | ||
| title: '저장', | ||
| isOverwrite: '기존 데이터를 덮어쓰시겠습니까？', |
There was a problem hiding this comment.
使用标准半角问号 ? 代替全角中文问号 ？，以与该文件中的其他翻译字符串保持一致。
| isOverwrite: '기존 데이터를 덮어쓰시겠습니까？', | |
| isOverwrite: '기존 데이터를 덮어쓰시겠습니까?', |
| }, | ||
| }; | ||
|
|
||
| export default zhCn; |
There was a problem hiding this comment.
导出 ko 变量而不是 zhCn。
| export default zhCn; | |
| export default ko; |
- Line 1: Change locale from zhCn to ko - Line 55: Replace full-width colon(：) with half-width colon (:) - Line 135: Replace full-width question Mark(？) to half-width question mark (?) - Line 205: Update export default from zhCn to ko
chore: update locale from zhCn to ko
|
其他字体均有韩文翻译， 但是“黑体”并没有所以未做翻译处理 |
2 participants
添加了韩文翻译