Fix filebucket REST terminus to support request.server#368
Open
mdechiaro wants to merge 1 commit intoOpenVoxProject:mainfrom
Open
Fix filebucket REST terminus to support request.server#368mdechiaro wants to merge 1 commit intoOpenVoxProject:mainfrom
mdechiaro wants to merge 1 commit intoOpenVoxProject:mainfrom
Conversation
Contributor
|
@mdechiaro thanks for the PR. can you please rebase against our main branch and add some tests for the change? |
mdechiaro
force-pushed
the
fix-centralized-filebuckets
branch
2 times, most recently
from
47346eb to
2aad445
Compare
Contributor
|
@mdechiaro please rebase against main, don't do a merge commit. And please signoff the commit ( |
mdechiaro
force-pushed
the
fix-centralized-filebuckets
branch
from
3e7d97a to
14e048b
Compare
Author
|
@bastelfreak sorry for the bad force push. Let me know if I should create a new PR and cherry-pick the change to clean this up. |
Contributor
|
if you do something like this: this should do the rebase + signoff. You can also hop into our IRC/slack channel if you need more help: https://voxpupuli.org/connect/ |
The REST terminus called session.route_to(:puppet) with no URL, so route_to always resolved via the normal resolver chain and sent filebucket traffic to Puppet[:server], silently ignoring the server value encoded in the filebucket:// URI. Add specs that stub only the explicit host (xanadu:8141) so WebMock raises if the request is routed to the wrong server. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Closes: OpenVoxProject#367 Signed-off-by: Mark Dechiaro <mdechiaro@users.noreply.github.com>
mdechiaro
force-pushed
the
fix-centralized-filebuckets
branch
from
2b4ad70 to
9a0264b
Compare
Author
|
@bastelfreak I believe I fixed my issues with merge and sign-off. Thanks for your help with this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The REST terminus called session.route_to(:puppet) with no URL, so route_to always resolved via the normal resolver chain and sent filebucket traffic to Puppet[:server], silently ignoring the server value encoded in the filebucket:// URI.
Co-Authored-By: Claude noreply@anthropic.com
Closes: #367