Start-AWSTest: check if MSI signature is valid before installation#24
Open
Start-AWSTest: check if MSI signature is valid before installation#24
Conversation
It might happen during the build that installer is not signed And it is hard to detect because of huge build output This check helps detect missing or not valid MSI signature Signed-off-by: Yuriy Darnobyt <yura.darnobyt@openvpn.net>
flichtenheld
requested changes
Feb 23, 2026
| $msiFileName = Split-Path "$MSI_PATH" -leaf | ||
| Invoke-Command -Session $Sess -ArgumentList $msiFileName -ScriptBlock { | ||
| $sig = Get-AuthenticodeSignature -FilePath "$HOME\$args" | ||
| if ($sig.Status -ne 'Valid') { |
Member
There was a problem hiding this comment.
This might break the GHA execution of these tests? I don't think we sign all the installers we test?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It might happen during the build that installer is not signed
And it is hard to detect because of huge build output
This check helps detect missing or not valid MSI signature