Skip to content

Conversation

@hmgaudecker
Copy link
Member

@hmgaudecker hmgaudecker commented Jan 18, 2026

  1. Reason: We want to support immutable mappings in pylcm (see issue #136).
  2. We can just work with strings internally (and will return strings) while not making assumptions about user code.

@codecov
Copy link

codecov bot commented Jan 18, 2026

Codecov Report

❌ Patch coverage is 97.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.48%. Comparing base (5893b76) to head (34e892a).

Files with missing lines Patch % Lines
tests/test_signature.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##           chore-improve-linting      #67      +/-   ##
=========================================================
- Coverage                  95.57%   95.48%   -0.09%     
=========================================================
  Files                         23       23              
  Lines                       1174     1151      -23     
=========================================================
- Hits                        1122     1099      -23     
  Misses                        52       52              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hmgaudecker hmgaudecker changed the title Change 'dict' annotations to 'Mapping' in order to accomodate immutab… Change 'dict' annotations to 'Mapping' Jan 18, 2026
@hmgaudecker hmgaudecker changed the title Change 'dict' annotations to 'Mapping' Change 'dict' annotations to 'Mapping'; do not require string annotations from users Jan 18, 2026
@hmgaudecker
Copy link
Member Author

Note: Docs failure is expected, will be fixed in #65

@hmgaudecker hmgaudecker requested a review from timmens January 18, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants