Adjust timer/messages in projector-detail #5709
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elblinator
added
the
enhancement
Member
luisa-beerboom
left a comment
luisa-beerboom
left a comment
There was a problem hiding this comment.
Looks good in general, but I have some questions
...p/site/pages/meetings/modules/projector/modules/countdown-time/countdown-time.component.scss
Show resolved
Hide resolved
...ors/modules/projector-detail/components/countdown-controls/countdown-controls.component.scss
Outdated
Show resolved
Hide resolved
...ctors/modules/projector-detail/components/countdown-controls/countdown-controls.component.ts
Show resolved
Hide resolved
Comment on lines
+67
to
+68
| const projections = this.projectorService.getMatchingProjectionsFromProjector(this.message, this.projector); | ||
| this.isProjected = !!projections.length; |
Member
Author
There was a problem hiding this comment.
same reasoning as above cannot be used here
I additionally found an bug in which the reference projector cannot be choosen in the dialog.
I will change some things here
Elblinator
force-pushed
the
5225-timer-messgaes-change
branch
from
3ac69e2 to
54bd246
Compare
Elblinator
added
the
waiting
Member
Author
|
waiting until projector merge is done |
Member
Author
|
Task:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5225