-
Notifications
You must be signed in to change notification settings - Fork 46
Fix CRs for paragraphs with empty first line #5340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Do not merge yet |
|
Please reassign me if approved |
ed0db4d to
22867e2
Compare
luisa-beerboom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine, minor remarks though
.../pages/meetings/pages/motions/services/common/motion-format.service/motion-format.service.ts
Outdated
Show resolved
Hide resolved
|
Found two issue during testing. Already talked with @bastianjoel about it. Full review follows. Need more test data.
|
|
@MSoeb The requested changes are fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found two Issues:
Projections of motions not possible (I guess it's because of the new projector service)-> projection have their own repository now- Found a failure in relation to issue #5165 . If I build a motion in the mentioned way and create a change recommendation to line one, two empty lines appears in the CR editor. The motion in normal view and the edtior of the motion instead show only one line. This also happens in empty line three. -> CR should not have two lines.
resolves #5164
resolves #5165
resolves #5355
reoslves potentionally OpenSlides/OpenSlides#6927
Needs:
OpenSlides/openslides-autoupdate-service#1329
OpenSlides/openslides-backend#3126
Additional Info:
OpenSlides/openslides-meta#307