Install OSI3 under conventional install locations#872
Closed
doganulus wants to merge 1 commit intoOpenSimulationInterface:masterfrom
Closed
Install OSI3 under conventional install locations#872doganulus wants to merge 1 commit intoOpenSimulationInterface:masterfrom
doganulus wants to merge 1 commit intoOpenSimulationInterface:masterfrom
Conversation
Contributor
|
This PR will be integrated in one of the other PRs related to the #870 - thank you for this very constructive proposal! |
pmai
added a commit
to OpenSimulationInterface/osi-cpp
that referenced
this pull request
Nov 5, 2025
Based on PRs OpenSimulationInterface/open-simulation-interface#872 and OpenSimulationInterface/open-simulation-interface#873 by @doganulus. Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
pmai
added a commit
to OpenSimulationInterface/osi-cpp
that referenced
this pull request
Nov 6, 2025
Based on PRs OpenSimulationInterface/open-simulation-interface#872 and OpenSimulationInterface/open-simulation-interface#873 by @doganulus. Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
Contributor
|
Handled via C++ repo PR OpenSimulationInterface/osi-cpp#5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The usual practice is to install libraries directly under
${INSTALL_PREFIX}/lib.This PR is a small step toward discussing the adoption of CMake’s
GNUInstallDirsconventions for standardized install locations.If this approach sounds reasonable, I’d prefer the OSI fully embrace
GNUInstallDirsconventions instead of using custom install location variables.