Conversation
MoralCode
left a comment
MoralCode
left a comment
There was a problem hiding this comment.
Overall looks good. still haven't had a chance to test on iOS, although the example app seems to run on android so that's a plus.
id be curious if any of the changes to *.xcworkspace files can be safely gitignored. i think some of these folders may be storing configuration specific to your IDE that dont need to be in the repo, but im not familiar enough with iOS to know what those are offhand.
| <key>NSBonjourServices</key> | ||
| <array> | ||
| <string>_dartobservatory._tcp</string> | ||
| </array> |
There was a problem hiding this comment.
i dont really understand this, but looks like some internal flutter thing. were these changes made by you or mostly automatic?
There was a problem hiding this comment.
I added this and found it from a stack overflow response. Can't remember from where but it got rid of some error I was facing. Could probably try without to see what it was.
|
Let me know once you get an iOS 16 device that can successfully run a test with a real piece. it works for me on Android and my iOS 15.7.1 device using the following procedure (in case anyone else is curious):
|
| <string>The app uses bluetooth to find, connect and transfer data between different devices</string> | ||
| <key>NSBluetoothPeripheralUsageDescription</key> | ||
| <string>The app uses bluetooth to find, connect and transfer data between different devices</string> | ||
| <key>UIBackgroundModes</key> |
There was a problem hiding this comment.
can we edit these descriptons to be more specific to this example app?
|
Since this change is specific to FlutterBleLib it has been superseded by #17. many of these core changes to bring the example app up to date and avoid errors by waiting for things to fully connect/set up before starting to perform actions like scanning or reading data |
|
well the other PR hasnt been merged yet and the ios plist changes probably would be helpful anyway, so this might still be useful. TBH i need to go back in and figure out what I was thinking with the reactive rewrite stuff |
|
Merged indirectly via #26 |
2 participants
No description provided.