front: fix origin arrival update time propagation + refactor time propagation#16231
Merged
front: fix origin arrival update time propagation + refactor time propagation#16231
Conversation
Contributor
|
Thanks for the fix ! Enregistrement.de.l.ecran.2026-04-15.a.14.56.21.mov |
Caracol3
reviewed
Apr 15, 2026
SharglutDev
approved these changes
Apr 17, 2026
Contributor
SharglutDev
left a comment
SharglutDev
left a comment
There was a problem hiding this comment.
Lgtm and tested, nice clean up !
Note
Seems like it's orthogonal to this PR but the optimistic update doesn't work well for the start time when propagation "toBeginning". On the video below, we can see a small delay before it's updated.
Enregistrement.de.l.ecran.2026-04-17.a.10.31.08.mov
Factoring the logic together will enable us to more easily add the special case for the origin, and makes the logic of the function more apparent. Signed-off-by: Alice Khoudli <alice.khoudli@polytechnique.org>
This change will both make handling the other cases than atThisWaypoint easier and DRYer, but also make the time propagation of the origin case naturally work for other callers of propagateTime, such as buildEditsForUpdate which creates the temporary state before the response from the back is received. Signed-off-by: Alice Khoudli <alice.khoudli@polytechnique.org>
Synar
force-pushed
the
ali/fix-refactor-propagate-time-expurged
branch
from
5c8c8f9 to
f3a4e63
Compare
Signed-off-by: Alice Khoudli <alice.khoudli@polytechnique.org>
Synar
force-pushed
the
ali/fix-refactor-propagate-time-expurged
branch
from
f3a4e63 to
dff4374
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #16164
Edit: I think my last commit was way over engineered, and there is a much simpler way. Pushed as a fixup.
(D -> D+1 changes are still not handled well, but the exact same issue seems to exist for non origin steps)