Skip to content

front: select edited train on update#16207

Merged
theocrsb merged 6 commits intodevfrom
ali/selected-edited-train-after-update
Apr 23, 2026
Merged

front: select edited train on update#16207
theocrsb merged 6 commits intodevfrom
ali/selected-edited-train-after-update

Conversation

@Synar
Copy link
Copy Markdown
Contributor

@Synar Synar commented Apr 11, 2026 •
edited
Loading

Close #16165

Select edited train upon saving

Edit:

  • also select created train upon creation
  • stop selecting first occurrence instead of base train when selecting a train by default
  • stop resetting the projected train id when selecting a train by default

@Synar Synar requested a review from a team as a code owner April 11, 2026 01:11
@github-actions github-actions Bot added the area:front Work on Standard OSRD Interface modules label Apr 11, 2026
@Synar Synar force-pushed the ali/selected-edited-train-after-update branch from 4bf1c8e to 6248291 Compare April 13, 2026 16:02
@Synar Synar requested review from kmer2016 and theocrsb April 13, 2026 16:39
theocrsb
theocrsb reviewed Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

When creating or deleting a train, the first instance is always selected

@Synar Synar force-pushed the ali/selected-edited-train-after-update branch from 6248291 to 5494078 Compare April 14, 2026 15:20
@Synar
Copy link
Copy Markdown
Contributor Author

Synar commented Apr 14, 2026 •
edited
Loading

Thanks for the suggestion, done and more @theocrsb ^^

Goal of the changes validated with @maelysLeratRosso

@Synar Synar requested a review from theocrsb April 14, 2026 15:24
kmer2016
kmer2016 reviewed Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, some few suggestion

Comment thread front/src/applications/operationalStudies/hooks/useAutoSelectTrainIds.ts Outdated
@Synar Synar force-pushed the ali/selected-edited-train-after-update branch from 5494078 to d75de7d Compare April 20, 2026 17:07
@Synar Synar requested a review from kmer2016 April 20, 2026 17:08
theocrsb
theocrsb approved these changes Apr 21, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested

kmer2016
kmer2016 approved these changes Apr 21, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Synar and others added 6 commits April 21, 2026 18:19
@Synar
front: select edited train on update
d608e53 
Signed-off-by: Alice Khoudli <alice.khoudli@polytechnique.org>
@Synar
front: select created train upon creation
3000f40 
Signed-off-by: Alice K. <alice.khoudli@gmail.com>
@Synar
front: stop selecting by default first occurrence instead of train
8e5edd9 
Signed-off-by: Alice K. <alice.khoudli@gmail.com>
@Synar
front: useautoselecttrainids: extract train id presence check to func…
f85411b 
…tion

This:
 - makes the code clearer
 - will enable further changes and fixes to this function
 - will enable us to use this logic for the projected id on top of the selected id

Signed-off-by: Alice K. <alice.khoudli@gmail.com>
@Synar
front: useautoselecttrainids: check occurrence exists not just base t…
1274576 
…rain

Signed-off-by: Alice K. <alice.khoudli@gmail.com>
@Synar
front: useautoselecttrainids: only reset projected id if invalid
a0bd5aa 
Signed-off-by: Alice K. <alice.khoudli@gmail.com>
@Synar Synar force-pushed the ali/selected-edited-train-after-update branch from d75de7d to a0bd5aa Compare April 21, 2026 16:20
@Synar Synar added this pull request to the merge queue Apr 22, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 23, 2026
@Synar Synar added this pull request to the merge queue Apr 23, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 23, 2026
@theocrsb theocrsb added this pull request to the merge queue Apr 23, 2026
Merged via the queue into dev with commit c1f2098 Apr 23, 2026
30 checks passed
@theocrsb theocrsb deleted the ali/selected-edited-train-after-update branch April 23, 2026 07:43
@Synar Synar mentioned this pull request Apr 23, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kmer2016 kmer2016 kmer2016 approved these changes

@theocrsb theocrsb theocrsb approved these changes

Assignees

No one assigned

Labels

area:front Work on Standard OSRD Interface modules

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Selection changes when editing

3 participants

@Synar @kmer2016 @theocrsb