Skip to content

Comments

Rust version of anim_to_vtk#101

Open
laurent-altr wants to merge 1 commit intoOpenRadioss:mainfrom
laurent-altr:rust/anim_to_vtk
Open

Rust version of anim_to_vtk#101
laurent-altr wants to merge 1 commit intoOpenRadioss:mainfrom
laurent-altr:rust/anim_to_vtk

Conversation

@laurent-altr
Copy link

Expected to be much faster (5-50x) than the C++

Copilot AI review requested due to automatic review settings February 18, 2026 13:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR replaces the C++ implementation of anim_to_vtk with a new Rust implementation, claiming 5-50x performance improvements. The rewrite adds support for binary VTK output, multi-threaded processing, and a legacy ASCII formatting mode for backward compatibility.

Changes:

  • Complete rewrite of anim_to_vtk from C++ to Rust with custom formatters and optimized I/O
  • New features: binary VTK output, parallel file processing, memory-aware thread pooling
  • Updated build scripts to use Cargo instead of C++ compilers, comprehensive documentation updates

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 15 comments.

Show a summary per file
File Description
output_converters/anim_to_vtk/src/main.rs New 2300-line Rust implementation with custom number formatting, VTK writer abstraction, and parallel processing
output_converters/anim_to_vtk/Cargo.toml Cargo manifest defining the Rust project with ryu dependency for fast float formatting
output_converters/anim_to_vtk/win64/build.bat Modified Windows build script to invoke cargo instead of Visual C++ compiler
output_converters/anim_to_vtk/linux64/build.bash Modified Linux x64 build script to invoke cargo and copy executable to exec directory
output_converters/anim_to_vtk/linuxa64/build.bash Modified Linux ARM64 build script to invoke cargo and copy executable to exec directory
output_converters/anim_to_vtk/README.md Extensive documentation updates covering new features, usage examples, and format options
output_converters/anim_to_vtk/PERFORMANCE.md New performance analysis document explaining optimization techniques and speedup claims
.gitignore Added Rust-specific ignore patterns (target/, Cargo.lock, exec/)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Expected to be much faster (5-50x) than the C++
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant