Skip to content

Conversation

@penev92
Copy link
Member

@penev92 penev92 commented Nov 24, 2024

There is one low-priority TODO on the map editor chrome region definitions. that the chrome.png is missing some icons.

I ran into two upstream issues with translations, which should be handled before a release. 🤷‍♂️

Straight-up copied the one from OpenRA.
As per OpenRA PRs 21379, 21523 and 21635.
As per OpenRA PR 21427.
penev92 added 11 commits April 6, 2025 17:58
OpenRA PR 21134.
Run utility command --extract-chrome-strings. NOTE: This expects that there is a /fluent folder with a /chrome.ftl file in your mod!
utility example --update-mod release-20231010 --detailed --apply
These should be the final changes to mod.yaml.
@penev92 penev92 marked this pull request as ready for review April 6, 2025 16:00
@penev92 penev92 changed the title Update the SDK scripts + Example mod to the upcoming OpenRA release Update the SDK scripts + Example mod to OpenRA release-20250330 Apr 6, 2025
@penev92
Copy link
Member Author

penev92 commented Apr 6, 2025

OK, this is now on-par with OpenRA release-20250330.
The CI checks are failing because the CheckFluentReferences lint test is failing on attempting to verify ResourceRendererInfo.ResourceTypeInfo.Name translations as there are no resources in the Example mod, so that is how things are going to be.

@pchote
Copy link
Member

pchote commented Apr 8, 2025

I suggest adding a
rm ${ENGINE_DIRECTORY}/OpenRA.Mods.Common/Lint/CheckFluentReferences.cs to
https://github.com/OpenRA/OpenRAModSDK/blob/master/fetch-engine.sh#L76 to squash the bogus lint failure.

@penev92
Copy link
Member Author

penev92 commented Apr 8, 2025

Removed the lint check.

@penev92
Copy link
Member Author

penev92 commented Apr 13, 2025

Fixed the CI issues.

Copy link
Member

@Mailaender Mailaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the glyphs.

@penev92
Copy link
Member Author

penev92 commented Apr 21, 2025

Added the missing glyphs.

@Mailaender Mailaender merged commit 0059e22 into OpenRA:master Apr 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants