f-#: Adds METHOD, DNS and GATEWAY parameters to VM template NIC docs#3114
Open
aleixrm wants to merge 2 commits into
Open
f-#: Adds METHOD, DNS and GATEWAY parameters to VM template NIC docs#3114aleixrm wants to merge 2 commits into
aleixrm wants to merge 2 commits into
Conversation
…entation Signed-off-by: Aleix Ramírez <aramirez@opennebula.io>
pedroielpi3
reviewed
Nov 28, 2024
pedroielpi3
left a comment
pedroielpi3
left a comment
Contributor
There was a problem hiding this comment.
For line 516 I suggest adding the backticks `` to the key=value pair, i.e.:
NIC DNS server. Please make sure that INHERIT_VNET_ATTR="DNS" is added to /etc/one/oned.conf.
Otherwise looks good to me
Signed-off-by: Aleix Ramírez <aramirez@opennebula.io>
Collaborator
Author
Sorry, I forgot it! Corrected 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds NIC configuration missing parameters to the VM template attribute reference.
Based on tf provider docs: https://registry.terraform.io/providers/OpenNebula/opennebula/latest/docs/resources/virtual_machine#method-1
Branches to which this PR applies