Make pyOpenMS build optional in Dockerfile and Windows workflows #294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dockerfile built pyOpenMS from source while Windows workflows installed from pip, creating an inconsistency.
Changes
Dockerfile
BUILD_PYOPENMSbuild arg (default:ON)ON: Builds OpenMS and pyOpenMS from source (existing behavior)OFF: Installs pyOpenMS from condaWindows Workflows
BUILD_PYOPENMSenv var (default:false) to bothbuild-windows-executable-app.yamlandbuild-windows-executable-app-with-pyinstaller.yamlfalse: Installs from pip (existing behavior)true: Builds from sourcebuild-openmsjob:PYOPENMSflagbuild-executablejob:Documentation
Defaults preserve existing behavior: Dockerfile builds from source, Windows workflows use pip.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.