-
Notifications
You must be signed in to change notification settings - Fork 35
Allow large amount of files in wix #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for contributing.
This is helpful for quickly testing the Wix packaging without building OpenMS (I will suggest keeping it as workflow_dispatch ). |
WalkthroughThe changes modify two GitHub Actions workflows. Both workflows now replace the Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant GH as GitHub Actions
participant Wix as WiX Tool
U->>GH: Manually trigger workflow (workflow_dispatch)
GH->>Wix: Process WiX XML (using MediaTemplate)
Wix->>GH: Generate .wixobj files
GH->>Wix: Link .wixobj files into .msi using -b SourceDir
GH->>GH: Upload artifacts (with formatting adjustments)
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
When adding additional dependencies in umetaflow, the file count limit of the
streamlit.cabfile was exceeded. This PR ensures that files are automatically distributed across multiple.cabfiles if necessary.I also enabled the
test-win-exe-w-embed-pyGA on PR to main. However, from what I saw it does not seem to test anything. @Arslan-Siraj can this be removed?Summary by CodeRabbit