Fix the Travis JS related tests#300
Fix the Travis JS related tests#300peternewman wants to merge 14 commits intoOpenLightingProject:masterfrom
Conversation
…refox via apt instead
daveol
left a comment
daveol
left a comment
There was a problem hiding this comment.
Overall seems fine, some minor nitpicks
| directories: | ||
| - $HOME/.npm | ||
| - $HOME/.cache/pip |
There was a problem hiding this comment.
Do we still need this if we use Travis's built-in definitions?
There was a problem hiding this comment.
Honestly I'm not sure. At one point caching was only available in the pro one unless you configured it yourself! I don't know if it dealt with such subtleties too, so I'm tempted to leave it given it doesn't really do any harm.
| before_cache: | ||
| - rm -f $HOME/.cache/pip/log/debug.log # erase log | ||
| - rm -f $HOME/.cache/pip/log/debug.log # erase log |
There was a problem hiding this comment.
Is this still needed when using Travis's built-in definitions for the cache?
There was a problem hiding this comment.
Honestly I'm not sure. At one point caching was only available in the pro one unless you configured it yourself! I don't know if it dealt with such subtleties too, so I'm tempted to leave it given it doesn't really do any harm.
3 participants
No description provided.