Fix ClosureJS error

[FloEdelmann]

This fixes the error mentioned in #128 (comment).

There are two warnings left when running grunt closure-compiler:

>> js_src/pid_display.js:46: WARNING - Property _pid never defined on app.MessageField
>> app.MessageField.prototype.pid = function() { return this._pid; };
>>                                                           ^^^^
>> 
>> js_src/pid_display.js:190: WARNING - Property update never defined on app.MessageGroup
>>       new_div.update(field['items']);
>>               ^^^^^^

I don't know enough of their purpose to decide what to do with them.

[FloEdelmann]

I always thought this was an object at first glance, so I changed it to make it more clear that it's a string.

[peternewman]

I wondered if that was a linter fix, but perhaps not looking at the blame.

[peternewman]

There's one more outstanding use of setHtml here

rdm-app/templates/browse_models.tmpl

Line 103 in 5980e12

tt.setHtml('RDM Responder Test Score: ' + rating + '%');

. Would you mind fixing that too please?

[peternewman]

I don't know how good the optimiser is, but this would be slightly better if it was just one concat of strings across two lines I think, or does it then throw an error and is that what the brackets were for?

[peternewman]

Hi @FloEdelmann ,

See also #210 which stops it moaning about closure code we can't control.

[peternewman]

I wonder if

js_src/pid_display.js:190: WARNING - Property update never defined on app.MessageGroup
new_div.update(field['items']);

Is because of the slightly odd dependency tree?

We define MessageStructure:
https://github.com/OpenLightingProject/rdm-app/blob/master/js_src/pid_display.js#L143-L146

Then it's update method (which refers to MessageGroup's update method):
https://github.com/OpenLightingProject/rdm-app/blob/master/js_src/pid_display.js#L179-L196

Finally we define MessageGroup as a child of MessageStructure:
https://github.com/OpenLightingProject/rdm-app/blob/master/js_src/pid_display.js#L206-L210

So it's all a bit circular! It might be worth trying to move the MessageGroup stuff above the update stuff and see if that fixes the warning.

[peternewman]

This one:

js_src/pid_display.js:46: WARNING - Property _pid never defined on app.MessageField
app.MessageField.prototype.pid = function() { return this._pid; };

Looks like a typo, or something that never got updated. Compare the JS Doc, to the code:
https://github.com/OpenLightingProject/rdm-app/blob/master/js_src/pid_display.js#L41-L45

In which case it's been wrong since the beginning:
50bdbdc

Anyway I suspect they should be:
app.MessageField.prototype.fieldInfo = function() { return this._field_info; };

Thoughts @nomis52 ?

[FloEdelmann]

Moving MessageGroup above MessageStructure.update didn't help unfortunately.

[peternewman]

Can we space the 'Name: ' bit to align below Type please.

[peternewman]

Done

[peternewman]

LGTM. While it doesn't fix all the outstanding errors it certainly looks to improve things!