Remove simplesender #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogin
force-pushed
the
remove-simplesender
branch
3 times, most recently
from
c96f617 to
c347fbe
Compare
jonbartels
approved these changes
Aug 5, 2025
kryskool
approved these changes
Aug 21, 2025
Collaborator
|
Gets rid of lots of useless code and helps with the move to Gradle. Is there a reason this hasn't been merged, @jonbartels? |
tonygermano
approved these changes
Nov 29, 2025
Member
tonygermano
left a comment
tonygermano
left a comment
There was a problem hiding this comment.
I'm ok with this. My only concern was that it might have had use in integration testing, but since we don't have those test scripts that may have utilized it there is no reason to keep it.
mgaffigan
approved these changes
Nov 29, 2025
Contributor
mgaffigan
left a comment
mgaffigan
left a comment
There was a problem hiding this comment.
Let's add a tag for last/simplesender for whatever commit is one before merge.
Closed
The simplesender sub-project is unmaintained and is not referenced elsewhere in the project. Issue: OpenIntegrationEngine#88 Signed-off-by: Richard Ogin <rogin@users.noreply.github.com> Signed-off-by: Tony Germano <tony@germano.name>
tonygermano
force-pushed
the
remove-simplesender
branch
from
c347fbe to
60f2da6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Issue #88
Searched the project for "simplesender". Removed its root folder then references in .gitignore.
Verified a successful build using Oracle JDK 8.