Fix apache-jsp jar, webapp loading, and .classpath files #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the version of apache-jsp was updated from 9.4.53 to 9.4.57 in 57bc9e7 it was accidentally replaced with the jar containing the source files rather than the compiled class files. Signed-off-by: Tony Germano <tony@germano.name>
Required to make some IDEs happy following the library upgrades introduced in 45c3e93 Signed-off-by: Tony Germano <tony@germano.name>
tonygermano
requested review from
a team,
jonbartels,
kayyagari,
mgaffigan and
ssrowe
and removed request for
a team
Collaborator
|
Looks absolutely fine to my eyes. This hopefully fixes the issues in VSCode. |
mgaffigan
previously approved these changes
Nov 29, 2025
tonygermano
requested review from
a team,
gibson9583 and
pacmano1
and removed request for
a team
updated setWar method to use full context path to support new Jetty version Cherry-picked-from: Innovar-Healthcare/BridgeLink@388cd0b Issue: Innovar-Healthcare/BridgeLink#65 Signed-off-by: Tony Germano <tony@germano.name>
tonygermano
changed the title
mgaffigan
approved these changes
Dec 1, 2025
ssrowe
approved these changes
Dec 2, 2025
kayyagari
approved these changes
Dec 2, 2025
kayyagari
left a comment
kayyagari
left a comment
There was a problem hiding this comment.
This is looking good, thank you for updating the .classpath file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the version of apache-jsp was updated from 9.4.53 to 9.4.57 in #146 it was accidentally replaced with the jar containing the source files rather than the compiled class files. The file in this PR was downloaded from https://repo1.maven.org/maven2/org/eclipse/jetty/apache-jsp/9.4.57.v20241219/apache-jsp-9.4.57.v20241219.jar. Additionally, this PR updates the .classpath files with the new dependencies from this PR and 146.
Edit: Third commit added, which was cherry-picked from Innovar-Healthcare/BridgeLink#67. This fixes a regression bug related to the updated jetty version not being able to load web apps. Our project does not currently build or ship any webapps, but to test I uncommented this block so the old webadmin would build and deploy. The BL PR also adds back the correct apache-jsp jar, which was already part of this PR.
engine/server/mirth-build.xml
Lines 30 to 34 in fa8957d