-
Notifications
You must be signed in to change notification settings - Fork 41
Added docker build and quick-start #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I updated #40 with how I think the "official" docker container should be implemented. However, I really like the idea of what is presented here to use docker as a developer tool for building and testing. I've also responded to some of your questions here #2 (comment) |
|
@tonygermano, I'm no longer aware of issues outside of the registry name (presumably someone owns the official URL?). Differences I'm aware of relative to the original repo:
Happy to discuss as needed. Every compose file, kubernetes deployment, etc... that I've tested doesn't notice the difference between this and stock. |
|
@mgaffigan I pulled your launcher script out of this PR, made significant changes, and put it in its own PR in #119 . I think it is useful outside of a docker context, and it can still be used with docker. Would you mind reviewing it and giving any feedback? |
|
@tonygermano, Excellent! I'd love to see that merged and agree it is useful outside of docker. |
a3709ea to
6b7246f
Compare
|
I've updated the PR to depend upon #119 for oieserver.sh and match the conventions of #126 assuming that has more community input. Currently blocked by merge of: #119 and #126 Process used for testing:
|
Don't link to #126, it is still a draft and not ready for review. |
25d21a6 to
944208e
Compare
| ## Build and run locally | ||
|
|
||
| To build the solution, you must have a Java 1.8 JDK+FX and Apache Ant. This | ||
| can be installed by [sdkman](https://sdkman.io/) by executing `sdk env install`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC SDKMan isn't supported on windows. Do you need separate *nix, mac, and winderz instructions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think *nix and mac can go as is, but windows should be clarified, yes. This also needs to be updated for the new Java 17 minimum build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated language to address windows.
| # 1b. Build the application | ||
| # 2. Runner Stage: Creates a lightweight image that runs the application using the JRE. | ||
|
|
||
| FROM ubuntu:noble-20251013 AS builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not latest - this is now 2 months out of date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ubuntu:noble-20251013 is current ubuntu LTS release. Specifying a specific tag is considered best practice for reproducible builds (though admittedly that would be a hash, not a tag, when taken to heart). Dependabot can submit PR's automatically to track latest, which keeps approval in the hands of the project.
I am unopposed to latest if preferred.
944208e to
a296c57
Compare
Adds docker build and configure-from-env script to configure OIE server based on environment variables at container startup time. Issue: OpenIntegrationEngine#40 Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
a296c57 to
ed66e29
Compare
While this might be somewhat responsive to #40, it is primarily just to provide a quick-start way for a developer to build and test. While trying to address Issue 5 I had hours of challenges getting things building happily - and shifted to docker as an escape hatch.
I do not expect this PR is ready to merge as is, but wanted to get something posted publicly. Known issues include:
That said, it does work to the point of passing tests, running server, client, and simple message processing.
I'm new to the project, so if I've missed a step please let me know.