Conversation
API breakage checks (Griffe)Result: Passed |
Agent server REST API breakage checks (OpenAPI)Result: Failed Log excerpt (first 1000 characters) |
Coverage Report •
|
||||||||||||||||||||
all-hands-bot
left a comment
There was a problem hiding this comment.
🟢 Good taste - Clean, pragmatic solution solving a real performance problem. No over-engineering, just straightforward implementation: optional parameter, conditional build skip, proper cleanup. Backward compatible, well-tested. This is how code should be written. LGTM! 🚀
Co-authored-by: openhands <openhands@all-hands.dev>
e1753d6 to
ed53ab2
Compare
Co-authored-by: openhands <openhands@all-hands.dev>
|
[Automatic Post]: It has been a while since there was any activity on this PR. @simonrosenberg, are you still working on it? If so, please go ahead, if not then please request review, close it, or request that someone else follow up. |
2 similar comments
|
[Automatic Post]: It has been a while since there was any activity on this PR. @simonrosenberg, are you still working on it? If so, please go ahead, if not then please request review, close it, or request that someone else follow up. |
|
[Automatic Post]: It has been a while since there was any activity on this PR. @simonrosenberg, are you still working on it? If so, please go ahead, if not then please request review, close it, or request that someone else follow up. |
|
@OpenHands can you fix merge conflict? @simonrosenberg is this still needed? |
|
I'm on it! xingyaoww can track my progress at all-hands.dev |
|
Not needed anymore. |
SummaryThe merge conflict in PR #2399 has been resolved and pushed. What was done:
Important note:With this merge resolution, the PR now carries no meaningful diff against main. The cache export control features this PR originally introduced have already been incorporated into main through other work. This confirms the reviewer's suspicion — this PR can likely be closed as its changes are already in main. Conciseness:The changes are minimal — a single merge commit with no extraneous modifications. No new code was added beyond what was needed to resolve the conflict. |
Summary
cache-toexport by default while keeping sharedcache-fromOPENHANDS_BUILDKIT_CACHE_MODE=off|min|maxso callers can disable or reducecache-toexportsScope
The prebuilt SDK sdist feature from this branch already merged separately in #2426, so this PR now carries only the remaining BuildKit cache export controls.
Behavior change
OPENHANDS_SHARED_REGISTRY_CACHE_EXPORT=1OPENHANDS_BUILDKIT_CACHE_MODE=max|min|offcontrols allcache-toexportsmaxkeeps full cache export behaviorminexports a smaller cacheoffdisables allcache-toexports while preservingcache-fromValidation
uv run pytest tests/agent_server/test_docker_build.pyuv run pre-commit run --files openhands-agent-server/openhands/agent_server/docker/build.py tests/agent_server/test_docker_build.pyAgent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.13-nodejs22golang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:9c0379f-pythonRun
All tags pushed for this build
About Multi-Architecture Support
9c0379f-python) is a multi-arch manifest supporting both amd64 and arm649c0379f-python-amd64) are also available if needed