-
Notifications
You must be signed in to change notification settings - Fork 7
docs: weekly architecture docs refresh #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Update agent-server.mdx to reflect current server responsibilities and endpoints (source: openhands-agent-server/*) - Fix security.mdx source link; add ConfirmationPolicy reference; add Last updated and Source commit footer Co-authored-by: openhands <openhands@all-hands.dev>
…)\n\nCo-authored-by: openhands <openhands@all-hands.dev>
…thored-by: openhands <openhands@all-hands.dev>
xingyaoww
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird -- i don't think agent server package is included in docs.json?
…ples, inline source links\n\nCo-authored-by: openhands <openhands@all-hands.dev>
…inline source links\n\nCo-authored-by: openhands <openhands@all-hands.dev>
Place agent-server at the end of the SDK Components section for consistent ordering. Co-authored-by: openhands <openhands@all-hands.dev>
67909cf to
f0328fa
Compare
…'Agent Server', and simplify selected endpoints Also keeps concise Client SDK REST + WebSocket examples with inline GitHub source links. Co-authored-by: openhands <openhands@all-hands.dev>
Added! But now I'm not sure: did we leave it out intently, for a reason like, we recommend to use the remote workspace to handle communication? That doesn't apply to communication from other languages than python, so it seems like it can be useful. On a side note, the existing document contained a lot of hallucinations, a lot fixed. 😅 |
|
@OpenHands We have syntax errors in mintlify for the two initial diagrams, please fix. This is one, but look at the next one too:
|
|
I'm on it! enyst can track my progress at all-hands.dev |
…ards, avoid /* and braces in labels)
- Replace '/api/*' and '/sockets/*' with safe labels in diagrams
- Replace '{id}' with '<id>' in node label
Co-authored-by: openhands <openhands@all-hands.dev>
|
Summary of changes just made What I fixed
Why it was failing
Precise edits
Validation
Commit
Next steps
|
…ver group\n\n- Remove sdk/arch/agent-server from SDK Components\n- Add sdk/arch/agent-server under Guides > Remote Agent Server (after overview)\n\nCo-authored-by: openhands <openhands@all-hands.dev>
xingyaoww
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The more i read into this doc, the more i feel it probably make sense to combine this docs with agent-server overview page we currently have, and have this doc link to specific docs of Docker/APIWorkspace when discussing about *Workspace that spawns agent server, wdyt?
Yes I feel maybe there’s some duplication. @OpenHands review the pages under agent-server and use your taste to combine meaningfully; link to workspaces. |
|
I'm on it! enyst can track my progress at all-hands.dev |
- Refactored sdk/arch/agent-server.mdx to focus on technical architecture: - Removed duplicate content and client SDK examples - Added clear API endpoints table - Added authentication table - Added links to workspace implementations (Docker, API, Cloud) - Added See Also section linking to guides - Refactored sdk/guides/agent-server/overview.mdx to focus on practical usage: - Renamed title to 'Remote Agent Server' for clarity - Removed duplicate architecture diagrams - Added workspace types comparison table - Added OpenHands Cloud workspace example - Simplified 'How It Works' section - Added links to architecture page for technical details - Updated Next Steps sections in all agent-server guide pages for consistency Co-authored-by: openhands <openhands@all-hands.dev>
Summary of ChangesI've consolidated the agent-server documentation pages to reduce duplication and improve clarity, as requested. The changes have been pushed to the What was done:1. Refactored
2. Refactored
3. Updated cross-links in all agent-server guide pages
Result:
The changes are already pushed to the PR branch. |
|
Just checking in @enyst are you still working on this? If so you could re-request review or make any changes. |
docs.json
Outdated
| "group": "Remote Agent Server", | ||
| "pages": [ | ||
| "sdk/guides/agent-server/overview", | ||
| "sdk/arch/agent-server", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OpenHands I think we already have in the overview page similar content with the agent-server page? Verify what I just said, and dedup: remove from agent-server page what we already basically cover in overview, and move from agent-server page to overview page the rest. Don't spend much explanations on workspaces, link to the respective workspace instead.
Do make sure to keep all contents about the seamless transition from local to remote, and of course the rest of the non-dupe content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm on it! enyst can track my progress at all-hands.dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've completed the deduplication of the overview and agent-server pages as requested. Here's a summary of the changes:
Changes Made
✅ Verified overlap and deduplicated content
- Confirmed that
sdk/arch/overview.mdxandsdk/arch/agent-server.mdxhad significant overlap in describing the Agent Server Package
✅ Moved unique content from agent-server.mdx to overview.mdx
The following unique content was moved to the "Agent Server Package" section in overview.mdx:
- Architecture diagram (FastAPI App, Routers, Services)
- Key Components table with source links
- API Endpoints tables (REST and WebSocket)
- Authentication details (HTTP header and WebSocket query param)
✅ Removed agent-server.mdx
- Deleted
sdk/arch/agent-server.mdxsince all its content is now consolidated in overview.mdx
✅ Updated navigation
- Removed
sdk/arch/agent-serverfrom docs.json navigation
✅ Updated all references
Updated 8 files that referenced the deleted page to point to the new location (/sdk/arch/overview#agent-server-package-openhandsagent_server):
- sdk/guides/agent-server/overview.mdx
- sdk/guides/agent-server/api-sandbox.mdx
- sdk/guides/agent-server/docker-sandbox.mdx
- sdk/guides/agent-server/local-server.mdx
- sdk/guides/agent-server/cloud-workspace.mdx
- sdk/arch/sdk.mdx
- sdk/arch/workspace.mdx
✅ Kept seamless transition content
The seamless local-to-remote transition content remains in sdk/guides/agent-server/overview.mdx (the practical guide)
✅ Linked to workspace docs instead of explaining
The overview now links to /sdk/arch/workspace for workspace implementation details rather than duplicating explanations
The changes have been pushed to the docs-weekly-arch-refresh branch on PR #169.
- Move unique content from sdk/arch/agent-server.mdx to sdk/arch/overview.mdx - Remove sdk/arch/agent-server.mdx (content now in overview) - Update all references to point to the new location - Update docs.json navigation to remove agent-server page Co-authored-by: openhands <openhands@all-hands.dev>
Summary of updates
This weekly refresh updates the SDK architecture documentation under sdk/arch based on the latest HEAD of OpenHands/software-agent-sdk (commit 93d405c9).
Updated pages
Citations (inline in the docs)
Source of truth
Process notes
@enyst can click here to continue refining the PR