fix: remove trailing comma from debug MPO JSON#1269
Draft
Travor278 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the trailing comma from
internvl_chat_gpt_oss/shell/data/debug_mpo.jsonso the file is valid JSON again.This only changes the debug MPO metadata file syntax. It does not change any training script defaults or dataset entries.
Related Issue
Resolves #1265.
Motivation and Context
The MPO shell scripts pass
shell/data/debug_mpo.jsonas--meta_path. Loading that file with Python'sjsonmodule currently raisesJSONDecodeErrorbecause standard JSON does not allow a trailing comma after the final object entry.How Has This Been / Can This Be Tested?
Tested locally on Windows with Anaconda
py311/ Python 3.11.15.Both JSON files parse successfully.
Checklist
debug_mpo.json.