Fix integer overflow in trade money calculation#319
Open
kwsantiago wants to merge 1 commit intoOpenFusionProject:masterfrom
Open
Fix integer overflow in trade money calculation#319kwsantiago wants to merge 1 commit intoOpenFusionProject:masterfrom
kwsantiago wants to merge 1 commit intoOpenFusionProject:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The trade confirmation handler computes new money balances using
int32_tarithmetic:Since
moneyandmoneyInTradeare bothint32_t, the intermediate sum can overflow, allowing players to end up with negative or wrapped-around money values. A crafted trade can exploit this for money duplication.What changed
int64_tbefore committing[0, INT32_MAX]