Fix duplicateExit authorization bypass#317
Open
kwsantiago wants to merge 1 commit intoOpenFusionProject:masterfrom
Open
Fix duplicateExit authorization bypass#317kwsantiago wants to merge 1 commit intoOpenFusionProject:masterfrom
kwsantiago wants to merge 1 commit intoOpenFusionProject:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
duplicateExitallows any connected client to force-disconnect any other player by sending aP_CL2LS_REQ_PC_EXIT_DUPLICATEpacket with an arbitrary username. The handler looks up the account by the provided name and callsexitDuplicate()without verifying that the requesting socket actually owns that account.This adds a check that the requesting socket's login session matches the account being exited.
What changed
loginSessions[sock].userID == account.AccountIDbefore callingexitDuplicate()Impact
Without this fix, any authenticated client can kick any other player off the login server by name.