-
Notifications
You must be signed in to change notification settings - Fork 14
New deploy command #1184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
New deploy command #1184
Conversation
|
TODO: add an env var PREFER_NEW_SYNC This can be set in .env for projects which use the new sync stuff, and mean you don't need to pass the --beta flag This should not be set on projects which need github sync |
b1b014f to
832437d
Compare
Need to add more tests to Project.merge
Tests needed
|
At this point deploy is almost totally written. But after a lot of struggle it's working! I hit a major problem in Also hit some problems in merge code where not all properties of project and workflow get merged. I knew that was coming, but I'd totally forgotten it. So far I've dropped in a quick fix Still to do:
|
|
Almost done, and I've tested that it basically works. There are no tests on deploy - I think I'll manually test a bit more and then come back and do tests later I want to check:
|
This PR basically makes
deploy --betafunctional (or it will do, when I finish)Re-write the
openfn project deploycommand:--no-confirmor-y--dry-runworksThis PR also cleans up some general issues in sync and v1 compatibility:
Future work (real soon):
project exportwill take the working or OR any project by identifier, and will write it to the file you give it in the format you wantFixes #1165
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy