fixed Collection naming bug and ignore improper Redfish formats #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… property Signed-off-by: rherrell <russ.herrell@hpe.com>
cayton
approved these changes
Dec 5, 2025
sunfish_plugins/events_handlers/redfish/redfish_event_handler.py
Outdated
Show resolved
Hide resolved
Signed-off-by: rherrell <russ.herrell@hpe.com>
Collaborator
Author
|
I think we are ready to merge into Main. |
rherrell
commented
Dec 8, 2025
Collaborator
Author
rherrell
left a comment
rherrell
left a comment
There was a problem hiding this comment.
Reviewed in group
mjaguil
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collection names were being improperly created due to a bug in the core library plug-in.
Likewise, if a json file is returned during a ResourceCreated event that is missing the @odata.type or @odata.id properties, (a malformed Redfish object), the json file cannot be parsed by the Sunfish handlers, resulting in garbage in the Redfish resource trees. Added a check for both these properties. This is still no guarantee that the json response is Redfish compliant, but does prevent totally bogus json files from creating all kinds of odd error messages and incorrect Redfish tree structures.