Updates to dev following PR#65 #73
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- TS_low_dummy was introcuced in PR69 but we already had a mechanism for it (using the `runOnce` flag. - The check of the output of turbsim was there before and was removed on PR69, only checking the presence and non-zero-bytes value of the output files. Now we put the check back. PR69 handles the errors in a different way and thus wouldn't need this check, but when using SLURM scripts it is still needed
the skipcheck flag allows us to test all the way to FF_setup, as opposed to stopping at the low-res generation
Removed in PR69, now added back in a more robust way. Just checking the existence of the file is not enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting several changes to
dev, to be merged before merging #65.