Skip to content

refactor: centralize TeamMember interface and add tag support#345

Merged
danielmarv merged 8 commits intomainfrom
341-oe-br
Apr 10, 2026
Merged

refactor: centralize TeamMember interface and add tag support#345
danielmarv merged 8 commits intomainfrom
341-oe-br

Conversation

@danielmarv
Copy link
Copy Markdown
Member

@danielmarv danielmarv commented Apr 10, 2026

Description

This pull request refactors how team member data is modeled and displayed, centralizing the TeamMember type and adding support for a new optional tag and tag color on team member cards. It also updates the UI to display these tags and adds test coverage to ensure they are shown correctly.

Type system and data model improvements:

UI enhancements:

  • Updated TeamCard to display a tag with a customizable background color if the tag field is present, using a default color when none is provided (src/components/about/TeamCard.tsx) [1] [2].

Data updates:

  • Added tag and tagColor fields for relevant team members in both German and English team data files (src/data/de/team.json, src/data/en/team.json) [1] [2] [3] [4].

Testing:

  • Added an end-to-end test to verify that team tags are visible on the About page in both locales (tests/e2e/about.spec.ts).

Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 📝 Documentation update
  • 🎨 Style/formatting
  • ♻️ Refactor
  • 🔧 Configuration
  • ⚡ Performance
  • 🧪 Tests
  • 🔐 Security

Related Issue(s)

Closes #334 #335

Changes Made

  • Change 1
  • Change 2
  • Change 3

How to Test

  1. Step 1
  2. Step 2
  3. Verify the expected behavior

Checklist

  • Code follows project style guidelines
  • Self-review conducted
  • Comments added for complex logic
  • Documentation updated (if needed)
  • No new warnings generated
  • Tests added/updated (if applicable)
  • All tests passing locally

Signed-off-by: Daniel Ntege <danientege785@gmail.com>
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 10, 2026

Deploy Preview for open-elements ready!

Name Link
🔨 Latest commit cf6bac1
🔍 Latest deploy log https://app.netlify.com/projects/open-elements/deploys/69d91554aa03e4000870f5d7
😎 Deploy Preview https://deploy-preview-345--open-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 72
Accessibility: 97
Best Practices: 92
SEO: 100
PWA: 60
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Signed-off-by: Daniel Ntege <danientege785@gmail.com>
Signed-off-by: Daniel Ntege <danientege785@gmail.com>
Signed-off-by: Daniel Ntege <danientege785@gmail.com>
Signed-off-by: Daniel Ntege <danientege785@gmail.com>
Signed-off-by: Daniel Ntege <danientege785@gmail.com>
Signed-off-by: Daniel Ntege <danientege785@gmail.com>
Signed-off-by: Daniel Ntege <danientege785@gmail.com>
@danielmarv danielmarv merged commit 5996088 into main Apr 10, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tags for team members

2 participants