refactor: centralize TeamMember interface and add tag support#345
Merged
danielmarv merged 8 commits intomainfrom Apr 10, 2026
Merged
refactor: centralize TeamMember interface and add tag support#345danielmarv merged 8 commits intomainfrom
danielmarv merged 8 commits intomainfrom
Conversation
Signed-off-by: Daniel Ntege <danientege785@gmail.com>
✅ Deploy Preview for open-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Daniel Ntege <danientege785@gmail.com>
Signed-off-by: Daniel Ntege <danientege785@gmail.com>
Jexsie
approved these changes
Apr 10, 2026
Signed-off-by: Daniel Ntege <danientege785@gmail.com>
Signed-off-by: Daniel Ntege <danientege785@gmail.com>
Signed-off-by: Daniel Ntege <danientege785@gmail.com>
Signed-off-by: Daniel Ntege <danientege785@gmail.com>
Signed-off-by: Daniel Ntege <danientege785@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This pull request refactors how team member data is modeled and displayed, centralizing the
TeamMembertype and adding support for a new optional tag and tag color on team member cards. It also updates the UI to display these tags and adds test coverage to ensure they are shown correctly.Type system and data model improvements:
TeamMemberinterface (and supporting types) insrc/types/team.ts, consolidating team member type definitions across the codebase and adding new optional fields:tagandtagColor(src/types/team.ts).TeamMembertype in the app to import from the new shared type, removing local interface duplications (src/app/[locale]/employees/[slug]/page.tsx,src/app/[locale]/posts/[...slug]/page.tsx,src/components/about/TeamCard.tsx) (src/app/[locale]/employees/[slug]/page.tsxL6-R6, src/app/[locale]/posts/[...slug]/page.tsxR8-L22, src/components/about/TeamCard.tsxL1-R16).UI enhancements:
TeamCardto display a tag with a customizable background color if thetagfield is present, using a default color when none is provided (src/components/about/TeamCard.tsx) [1] [2].Data updates:
tagandtagColorfields for relevant team members in both German and English team data files (src/data/de/team.json,src/data/en/team.json) [1] [2] [3] [4].Testing:
tests/e2e/about.spec.ts).Type of Change
Related Issue(s)
Closes #334 #335
Changes Made
How to Test
Checklist