Skip to content

Fix image_groups.txt nested recursion issue #1971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thadwald wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix image_groups.txt nested recursion issue #1971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd35082
fix(photo): handle special case for Mavic 3E backward-facing images
thadwald Dec 22, 2025
d45619e
fix(osfm): add 'split_image_groups' to remove_always list in get_subm…
thadwald Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion opendm/osfm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -657,7 +657,7 @@ def get_submodel_argv(args, submodels_path = None, submodel_name = None):
reading the contents of --boundary
"""
assure_always = ['orthophoto_cutline', 'dem_euclidean_map', 'skip_3dmodel', 'skip_report']
remove_always = ['split', 'split_overlap', 'rerun_from', 'rerun', 'gcp', 'end_with', 'sm_cluster', 'rerun_all', 'pc_csv', 'pc_las', 'pc_ept', 'tiles', 'copy-to', 'cog']
remove_always = ['split', 'split_overlap', 'split_image_groups', 'rerun_from', 'rerun', 'gcp', 'end_with', 'sm_cluster', 'rerun_all', 'pc_csv', 'pc_las', 'pc_ept', 'tiles', 'copy_to', 'cog']
read_json_always = ['cameras', 'boundary']

argv = sys.argv
Expand Down
9 changes: 9 additions & 0 deletions opendm/photo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,6 +471,15 @@ def parse_exif_values(self, _path_file):
# Roll: 0 (assuming gimbal)
if self.has_ypr():
if self.camera_make.lower() in ['dji', 'hasselblad']:

# Mavic 3E smart oblique backward-facing images need special treatment
# backward-facing images are identified with a 180º roll
if abs(self.roll) > 90:
# Camera faces opposite direction
self.yaw = (self.yaw + 180) % 360
# Pitch axis is inverted in flipped frame
self.pitch = -self.pitch

self.pitch = 90 + self.pitch

if self.camera_make.lower() == 'sensefly':
Expand Down