Use spotless for auto-formatting and validate code with checkstyle #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotStirred
reviewed
Jun 16, 2025
Member
NotStirred
left a comment
NotStirred
left a comment
There was a problem hiding this comment.
Looks great, some minor things
Commented out code being formatted as comments looks pretty bad though
src/main/java/io/github/opencubicchunks/cubicchunks/CubicChunks.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/opencubicchunks/cubicchunks/client/multiplayer/ClientCubeCache.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/opencubicchunks/cubicchunks/config/ServerConfig.java
Outdated
Show resolved
Hide resolved
...io/github/opencubicchunks/cubicchunks/mixin/access/client/SectionRenderDispatcherAccess.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/opencubicchunks/cubicchunks/mixin/access/client/ViewAreaAccess.java
Outdated
Show resolved
Hide resolved
.../opencubicchunks/cubicchunks/mixin/core/common/server/level/MixinChunkMap$TrackedEntity.java
Show resolved
Hide resolved
src/main/java/io/github/opencubicchunks/cubicchunks/world/level/cube/LevelCube.java
Outdated
Show resolved
Hide resolved
NotStirred
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might want to review this one commit-by-commit 😉
GitHub CI should probably be updated to run checkstyle as its own task so it's easier to tell at a glance what exactly failed; but at any rate checkstyle failures will at least result in a CI failure as far as I can tell (since the test CI runs gradle
check)Merging the PR will change commit hashes, so I'll update
.git-blame-ignore-revsin a separate PR after this is merged.