Skip to content

Conversation

@NotStirred
Copy link
Member

No description provided.

@NotStirred NotStirred requested a review from CursedFlames June 15, 2025 00:42
@NotStirred
Copy link
Member Author

NotStirred commented Jun 15, 2025

Oh I'll clarify the new inspection, if GlobalSet has a container A but CloToChunkSet doesn't it's possible to do CloToChunkSet.A which is a completely different behaviour (dasm adds to globalset despite appearing to add to chunktoclo).

The inspection just shows an error but doesn't stop the build (ideally it would but not sure how)

Copy link
Member

@CursedFlames CursedFlames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits, went ahead and fixed them myself, otherwise lgtm 👍

@CursedFlames CursedFlames enabled auto-merge (rebase) June 15, 2025 03:04
@CursedFlames CursedFlames merged commit 9228116 into OpenCubicChunks:dev Jun 15, 2025
3 checks passed
@NotStirred NotStirred deleted the chore/dasm_2.5.2 branch June 15, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants