Port to 1.21.5 #70
Merged
Port to 1.21.5 #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChunkStatus package change ChunkStatus.ChunkType -> ChunkType Either -> ChunkResult registryOrThrow -> lookupOrThrow getMinBuildHeight -> getMinY getMaxBuildHeight -> getMaxY getMinSection -> getMinSectionY getMaxSection -> getMaxSectionY getStatus -> getPersistedStatus setStatus -> setPersistedStatus TicksToSave -> PackedTicks ConstructorSuper -> CTOR_HEAD
It will be entirely rewritten, so deleting the old code in a separate commit makes the commit diffs look nicer
NotStirred
requested changes
Jun 11, 2025
Member
NotStirred
left a comment
NotStirred
left a comment
There was a problem hiding this comment.
We're on latest! A few discussion points, everything else is nits :)
Random non-blocking notes:
ClientCubeCache$Storagehaving everything namedChunkmakes me feel uncomfortable, especiallygetChunk(I)LevelChunk->getChunk(I)LevelCube
...ain/java/io/github/opencubicchunks/cubicchunks/mixin/core/client/renderer/MixinViewArea.java
Outdated
Show resolved
Hide resolved
...cubicchunks/mixin/core/client/renderer/chunk/MixinSectionRenderDispatcher$RenderSection.java
Show resolved
Hide resolved
...cubicchunks/mixin/core/client/renderer/chunk/MixinSectionRenderDispatcher$RenderSection.java
Outdated
Show resolved
Hide resolved
...hub/opencubicchunks/cubicchunks/mixin/core/common/server/level/MixinChunkGenerationTask.java
Outdated
Show resolved
Hide resolved
...hub/opencubicchunks/cubicchunks/mixin/core/common/server/level/MixinChunkGenerationTask.java
Show resolved
Hide resolved
...java/io/github/opencubicchunks/cubicchunks/mixin/core/common/server/level/MixinChunkMap.java
Outdated
Show resolved
Hide resolved
...java/io/github/opencubicchunks/cubicchunks/mixin/core/common/server/level/MixinChunkMap.java
Show resolved
Hide resolved
...java/io/github/opencubicchunks/cubicchunks/mixin/core/common/server/level/MixinChunkMap.java
Outdated
Show resolved
Hide resolved
...b/opencubicchunks/cubicchunks/mixin/core/common/server/level/MixinGenerationChunkHolder.java
Show resolved
Hide resolved
src/main/java/io/github/opencubicchunks/cubicchunks/world/level/cube/LevelCube.java
Outdated
Show resolved
Hide resolved
NotStirred
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
good luck :)