Skip to content

Fix wrong calculation of required amount of ExtendedBlockStorage's #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hohserg1 wants to merge 2 commits into
base: MC_1.12
Choose a base branch
from
Open

Fix wrong calculation of required amount of ExtendedBlockStorage's #776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
338b6d8
Fix wrong calculation of required amount of ExtendedBlockStorage's
hohserg1 Jan 11, 2024
9161aa7
Added explcit meaning to javadoc of IMinMaxHeight
hohserg1 Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...hunksAPI/src/main/java/io/github/opencubicchunks/cubicchunks/api/world/IMinMaxHeight.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@
@MethodsReturnNonnullByDefault
public interface IMinMaxHeight {
/**
* Returns Y position of the bottom block in the world
* Returns Y position of the bottom block in the world,
* inclusive
*
* @return the bottom of the world
*/
Expand All @@ -42,6 +43,7 @@ default int getMinHeight() {

/**
* Returns Y position of block above the top block in the world,
* exclusive
*
* @return the top of the world
*/
Expand Down
4 changes: 3 additions & 1 deletion ...va/io/github/opencubicchunks/cubicchunks/core/asm/mixin/core/common/MixinChunk_Cubes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,9 @@ private int modifySectionArrayLength(int sixteen, World worldIn, int x, int z) {
}
if (!((ICubicWorld) worldIn).isCubicWorld()) {
IMinMaxHeight y = (IMinMaxHeight) worldIn;
return Coords.blockToCube(y.getMaxHeight()) - Coords.blockToCube(y.getMinHeight());
int firstInclusiveY = y.getMinHeight();
int lastInclusiveY = y.getMaxHeight() - 1;
return Coords.blockToCube(lastInclusiveY) - Coords.blockToCube(firstInclusiveY) + 1;
}
return sixteen;
}
Expand Down