Upgrade Symfony 6.4 > 7.4 #463

johanib · 2026-01-08T08:59:15Z

After merging, also merge:
OpenConext/OpenConext-devconf#72

Prior to this change, clearing the cache required the manual correction of the var/log and var/cache dirs to be owned by 33/www-data. This change corrects this on frontend-install automatically.

- fix phplint cache dir - make phpunit fail in dev on any deprecation warning - update phpstan baseline after update

The button group does not have data to map so needs mapped > false. And no data to inherit as wel. Symfony became more strict.

…onfig node

RecastingRemovalRector RemoveUselessParamTagRector RemoveUselessReturnTagRector

MKodde

I do not see any definitive requests for changes. Although some of my feedback might require some minor rework. See what clicks with you and feel free to discuss.

MKodde · 2026-01-20T10:27:21Z

ci/qa/phpstan.neon

 rules:

 parameters:
+    treatPhpDocTypesAsCertain: false


Should we add this for the other StepUp projects? Or maybe ensure we do not need it here? The other projects do not seem to have this setting? I'm not rejecting the PR because of this, just curious.

Initially, I thought this created a lot of issues. But 4, with 1 being fixable.
So removed it for now. We don't usually have this.

MKodde · 2026-01-20T10:35:13Z

src/Surfnet/StepupRa/RaBundle/DateTime/DateTime.php


 use DateTime as CoreDateTime;

 class DateTime


Is this class used anywhere? I could not find any usages myself. The Surfnet\StepupRa\RaBundle\Value\DateTime seems to be used instead.

👀 good spot. It is unused.

MKodde · 2026-01-20T10:49:05Z

src/Surfnet/StepupRa/RaBundle/Value/DateTime.php

    public static function now(): DateTime
    {
-        return self::$now ?: new self(new CoreDateTime);
+        return self::$now ?? new self(new CoreDateTime);


Does this change cause the addition of the phpstan-ignore-next-line property.unusedType ? This feels like a low gain optimization.

the ignore is needed because this is how $now is used:

$nowProperty = new ReflectionProperty(DateTime::class, 'now'); $nowProperty->setValue(null, $now);

I thought ?? was because of phpstan, but it is not, so reverted to ?:

MKodde · 2026-01-20T11:02:21Z

src/Surfnet/StepupRa/RaBundle/Twig/Extensions/Extension/Spaceless.php

+ * between a closing angle bracket and an opening angle bracket (">   <" => "><"). Whitespace inside
+ * tags or textual content is preserved.
+ */
+class Spaceless


1: I'd expect the introduction of this replacement feature to be in a commit of it's own. But OK to keep it like this..
2: Have you tried to use the 'replacement' feature that was introduced?

See: https://twig.symfony.com/doc/3.x/templates.html#whitespace-control

I don't know the exact reason why the spaceless is used here. I cannot confidently determine if the whitespace control does the exact same. It seems more targeted towards specific expressions. So I opted for this to be 100% backwards compatible.

New code should use the whitespace control.

MKodde · 2026-01-20T11:05:59Z

src/Surfnet/StepupRa/RaBundle/Controller/RaManagementController.php

+        $command->orderBy = $request->query->get('orderBy');
+        $command->orderDirection = $request->query->get('orderDirection');


Why not use the trait here?

This targeted way is still preferred imo. The trait is because the GET + POST + default lines got too long and messy.. This only does GET + default

MKodde · 2026-01-20T11:09:18Z

src/Surfnet/StepupRa/RaBundle/Controller/Traits/OrderFromRequest.php

+
+use Symfony\Component\HttpFoundation\Request;
+
+trait OrderFromRequest


Maybe create two dedicated methods; one to get the sort order and one to get the column to sort on? orderBy & orderDirection. That way the trait becomes more focused on this specific purpose. I would be OK with hard coding the name of the request parameter for these methods. They always seem to be: orderDirection and orderBy.

MKodde · 2026-01-20T11:10:14Z

src/Surfnet/StepupRa/RaBundle/Controller/RaManagementController.php

+        $command->orderBy = $this->getString($request, 'orderBy');
+        $command->orderDirection = $this->getString($request, 'orderDirection');


Use OrderFromRequest trait?

it does? ;)

- Drop unused DateTime - Small refactorings & improvements

johanib added 7 commits January 7, 2026 16:06

DX: frontend-install sets correct var permissions

b4c242f

Prior to this change, clearing the cache required the manual correction of the var/log and var/cache dirs to be owned by 33/www-data. This change corrects this on frontend-install automatically.

Basic package update

85daf8c

- fix phplint cache dir - make phpunit fail in dev on any deprecation warning - update phpstan baseline after update

Update PHPStan and fix basic errors

509d970

Fix more phpstan issues after upgrade

5ebd44d

Add rector scripts & run apply SimplifyFormRenderingRector

894245b

Apply Attributes via Rector

62c1af4

Apply withPhpSets rectors

ec8232b

johanib force-pushed the feature/updates branch from 246ed4b to ec8232b Compare January 13, 2026 08:38

johanib added 4 commits January 13, 2026 10:05

Upgrade phpunit 9 > 10

7dcc127

Update Symfony 6.4 > 7.4

464ffb2

Fix qa errors

7495f7b

Update release notes & fix build

ae1d727

johanib force-pushed the feature/updates branch from 8708c9a to ae1d727 Compare January 13, 2026 14:58

johanib added 4 commits January 15, 2026 12:08

Resolve Symfony deprecations and errors.

02f08f5

The button group does not have data to map so needs mapped > false. And no data to inherit as wel. Symfony became more strict.

Resolve Symfony deprecations: get() and ignored default on required c…

1b45e18

…onfig node

Rector cleanup:

f850e2f

RecastingRemovalRector RemoveUselessParamTagRector RemoveUselessReturnTagRector

Update frontend tooling

2e05d89

johanib marked this pull request as ready for review January 15, 2026 14:05

johanib requested a review from MKodde January 15, 2026 14:05

Use latest 6.0.0 release of surfnet/stepup-middleware-client-bundle

c41fb57

MKodde approved these changes Jan 20, 2026

View reviewed changes

johanib added 2 commits January 20, 2026 16:13

Update component_info to match SF 7

0935bad

Rework

4283461

- Drop unused DateTime - Small refactorings & improvements

		$command->orderBy = $request->query->get('orderBy');
		$command->orderDirection = $request->query->get('orderDirection');


		use Symfony\Component\HttpFoundation\Request;

		trait OrderFromRequest

		$command->orderBy = $this->getString($request, 'orderBy');
		$command->orderDirection = $this->getString($request, 'orderDirection');

Upgrade Symfony 6.4 > 7.4 #463

Are you sure you want to change the base?

Upgrade Symfony 6.4 > 7.4 #463

Uh oh!

Conversation

johanib commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MKodde left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MKodde Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

johanib commented Jan 8, 2026 •

edited

Loading

MKodde Jan 20, 2026 •

edited

Loading